Close mobile nav when navigating to profile#620
Merged
realproject7 merged 1 commit intomainfrom Mar 27, 2026
Merged
Conversation
Add onNavigate callback prop to ConnectWallet, called on profile link click. NavBar passes setMobileOpen(false) from the mobile dropdown. Desktop behavior unaffected (onNavigate is optional/undefined). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
project7-interns
approved these changes
Mar 27, 2026
Collaborator
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
The PR fixes the mobile-nav profile-navigation bug by threading an optional onNavigate callback from the mobile dropdown into ConnectWallet and invoking it on the profile link only.
Findings
- None.
Decision
Approved because the change matches issue #615, stays tightly scoped to the affected mobile menu path, and leaves desktop behavior unchanged by keeping the callback optional.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #615
onNavigatecallback prop toConnectWallet() => setMobileOpen(false)from the mobile dropdownConnectWalletrenders without the prop (unchanged behavior)Test plan
🤖 Generated with Claude Code